Skip to content

Add support for custom attributes #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for custom attributes #123

wants to merge 2 commits into from

Conversation

spencer-cdw
Copy link

@spencer-cdw spencer-cdw commented May 21, 2025 •
edited
Loading

Resolves #106

AI was used in the creation of this PR, however it has been tested and is working.

Requirements.txt

  - name: ibm_messaging.ibm_mq
    version: feature/106
    source: https://github.com/spencer-cdw/mq-ansible
    type: git

Playbook

    - name: Create a queue manager
      ibm_messaging.ibmmq.queue_manager:
        qmname: OMS_QM_POC
        data_dir: /mnt/omssoftware/mqha/WMQ/OMS_QM_POC/data
        log_dir: /mnt/omssoftware/mqha/WMQ/OMS_QM_POC/logs
        log_file_size: 8192
        log_primary: 200
        log_secondary: 200
        state: running

@spencer-cdw spencer-cdw mentioned this pull request May 21, 2025
Open
@spencer-cdw spencer-cdw marked this pull request as ready for review June 3, 2025 18:01
@marianavillarp
Copy link
Contributor

Hi @spencer-cdw, thank you for raising this PR and contributing to the mq-ansible open source project.
The team will aim to review and test the proposed changes as soon as possible.

@marianavillarp
Copy link
Contributor

I had a look at the code and did some tests. Most of it looks good:

  • single queue manager with most of the flags (-md, -ld, -lf, -lp, -ls)
  • multiple queue managers with most of the flags
  • single queue manager, flags specified and mqsc provided.
  • multiple queue managers, flags specified and mqsc provided.
  • Each flag work individually.

From the last test noticed that flag '-q' fails. This is due to -q not being the 'description' flag, but the default flag. Could either remove the funtionality or modify it? Thanks :)

@marianavillarp marianavillarp self-requested a review June 19, 2025 12:55
marianavillarp
marianavillarp requested changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@marianavillarp marianavillarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flag '-q' fails. This is due to -q not being the 'description' flag, but the default flag. (copying the last comment as my review)

@marianavillarp
Copy link
Contributor

Hi @spencer-cdw, just keeping track of this PR.

Thanks again for your contribution - we really appreciate it and would like to include it in the mq-ansible repo.
We're happy to take care of the minor changes needed to get the PR approved and merged. If you have any thoughts or questions, feel free to share them please! Otherwise, if we don’t hear back, we’ll assume you're happy for us to proceed.

Thanks very much!

@spencer-cdw
Copy link
Author

Thanks for the feedback and catching that mistake. I've fixed the -q to actually point to -c which is the correct description flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marianavillarp marianavillarp marianavillarp requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add capabilties to use crtmqm flags such as (-fs, -lp, -ls , -lc , -lf, -h, -u, -p)
2 participants
@spencer-cdw @marianavillarp